Mockup for gTTS support (see #59) #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually it does work as-is. I was pointing the script to the wrong directory. Please review and merge. |
NicoHood
approved these changes
Oct 16, 2022
|
@nims11 your feedback? |
NicoHood
reviewed
Oct 17, 2022
| @@ -124,6 +124,14 @@ def check_support(): | |||
| else: | |||
| voiceoverAvailable = True | |||
|
|
|||
| # Check for gtts-cli voiceover | |||
| # https://github.com/pndurette/gTTS | |||
| if not exec_exists_in_path("gtts-cli"): | |||
There was a problem hiding this comment.
oh wait, we need to check for ffmpeg here as well, right?
There was a problem hiding this comment.
Dont we also need to check for sox of rhvoice? This is not related to this PR, but I just found this there as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #59.
Everything works as it should, but the generated wavefile doesn't play on the iPod.
Do we need to encode it in a certain way with ffmpeg?